GetLinesInViewport should consider ignore unchanged. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #122 |
|
@kingcean Could you review? |
|
@kbeatty-ascensionas Can you share an example text to test with to see the behavior so I can validate? |
|
What I was seeing is the early breakout in the loop would happen as soon as the first not in the viewport line was encountered. This was exposed by my previous fix that marked zero height lines as NOT being in the view. Ignore the image, it illustrates my previous fix. Not this one. |
|
|
|
@mmanela do you have any comments on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.