Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RasterMetricSpace for improved pairwise sampling of large 2D grids #114
Add RasterMetricSpace for improved pairwise sampling of large 2D grids #114
Changes from 10 commits
5bc6b74
fee0f3f
4ae5838
aa7fc55
7dde22a
20420fb
dd89a1b
48d0f50
3125aab
fccd0c6
a5702c9
dbf8aad
8ac7a1c
db879e2
e30722a
af35fe9
ff0afa5
63c128b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why sqrt(2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the surface area of successive rings is going to be preserved when increasing the radius by a factor of exactly
sqrt(2)
. The equation for the area of the ring (disk minus disk) looks like this (once the pis that even out are removed):(sqrt(2)R)**2 - R**2 = R**2
It's briefly described in the class description + the
__init__
function at the line it uses the factor