Enable integer selection for inactive molecules #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In topology, enable integer number of particles to deactivate (in addition to the boolean)
Renaming for improved reability. isAtomic() and isMolecular() added to Group which references MoleculeData directly, meaning the `atomic` member variable could be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the topology, enable integer number of particles to deactivate (in addition to the boolean).
Independently requested by @SHervoe-Hansen and @MarcoPolimeni.
This has turned out to be a refactoring commit for
Spacewith updated insertion methods to better accommodate changes like this one.