-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add additional credential types #38
Open
rohanmahy
wants to merge
2
commits into
mlswg:main
Choose a base branch
from
rohanmahy:more-credentials
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1205,6 +1205,106 @@ it carries no additional data. | |||||
As a result, a LastResort Extension contains the ExtensionType with an empty | ||||||
`extension_data` field. | ||||||
|
||||||
## Multi-Credentials | ||||||
|
||||||
Multi-credentials address use cases where there might not be a single | ||||||
credential that captures all of a client's authenticated attributes. For | ||||||
example, an enterprise messaging client may wish to provide attributes both | ||||||
from its messaging service, to prove that its user has a given handle in | ||||||
that service, and from its corporate owner, to prove that its user is an | ||||||
employee of the corporation. Multi-credentials can also be used in migration | ||||||
scenarios, where some clients in a group might wish to rely on a newer type | ||||||
of credential, but other clients haven't yet been upgraded. | ||||||
|
||||||
New safe credential types `MultiCredential` and `WeakMultiCredential` are | ||||||
defined as shown below. These credential types are indicated with | ||||||
ExtensionType values `multi` and `weak-multi` (see {{iana-creds}}). | ||||||
|
||||||
~~~ tls-presentation | ||||||
struct { | ||||||
CipherSuite cipher_suite; | ||||||
Credential credential; | ||||||
SignaturePublicKey credential_key; | ||||||
|
||||||
/* SignWithLabel(., "CredentialBindingTBS", CredentialBindingTBS) */ | ||||||
opaque signature<V>; | ||||||
} CredentialBinding | ||||||
|
||||||
struct { | ||||||
CredentialBinding bindings<V>; | ||||||
} MultiCredential; | ||||||
|
||||||
struct { | ||||||
CredentialBinding bindings<V>; | ||||||
} WeakMultiCredential; | ||||||
~~~ | ||||||
|
||||||
The two types of credentials are processed in exactly the same way. The only | ||||||
difference is in how they are treated when evaluating support by other clients, | ||||||
as discussed below. | ||||||
|
||||||
## Credential Bindings | ||||||
|
||||||
A multi-credential consists of a collection of "credential bindings". Each | ||||||
credential binding is a signed statement by the holder of the credential that | ||||||
the signature key in the LeafNode belongs to the holder of that credential. | ||||||
Specifically, the signature is computed using the MLS `SignWithLabel` function, | ||||||
with label `"CredentialBindingTBS"` and with a content that covers the contents | ||||||
of the CredentialBinding, plus the `signature_key` field from the LeafNode in | ||||||
which this credential will be embedded. | ||||||
|
||||||
~~~ tls-presentation | ||||||
struct { | ||||||
CipherSuite cipher_suite; | ||||||
Credential credential; | ||||||
SignaturePublicKey credential_key; | ||||||
SignaturePublicKey signature_key; | ||||||
} CredentialBindingTBS; | ||||||
~~~ | ||||||
|
||||||
The `cipher_suite` for a credential is NOT REQUIRED to match the cipher suite | ||||||
for the MLS group in which it is used, but MUST meet the support requirements | ||||||
with regard to support by group members discussed below. | ||||||
|
||||||
## Verifying a Multi-Credential | ||||||
|
||||||
A credential binding is supported by a client if the client supports the | ||||||
credential type and cipher suite of the binding. A credential binding is valid | ||||||
in the context of a given LeafNode if both of the following are true: | ||||||
|
||||||
* The `credential` is valid according to the MLS Authentication Service. | ||||||
|
||||||
* The `credential_key` corresponds to the specified `credential`, in the same | ||||||
way that the `signature_key` would have to correspond to the credential if | ||||||
the credential were presented in a LeafNode. | ||||||
|
||||||
* The `signature` field is valid with respect to the `signature_key` value in | ||||||
the leaf node. | ||||||
|
||||||
A client that receives a credential of type `multi` in a LeafNode MUST verify | ||||||
that all of the following are true: | ||||||
|
||||||
* All members of the group support credential type `multi`. | ||||||
|
||||||
* For each credential binding in the multi-credential: | ||||||
|
||||||
* Every member of the group supports the cipher suite and credential type | ||||||
values for the binding. | ||||||
|
||||||
* The binding is valid in the context of the LeafNode. | ||||||
|
||||||
A client that receives a credential of type `weak-multi` in a LeafNode MUST verify | ||||||
that all of the following are true: | ||||||
|
||||||
* All members of the group support credential type `multi`. | ||||||
|
||||||
* Each member of the group supports at least one binding in the | ||||||
multi-credential. (Different members may support different subsets.) | ||||||
|
||||||
* Every binding that this client supports is valid in the context of the | ||||||
LeafNode. | ||||||
|
||||||
|
||||||
# IANA Considerations | ||||||
|
||||||
This document requests the addition of various new values under the heading | ||||||
|
@@ -1389,7 +1489,7 @@ from a group more efficiently than using a `remove` proposal type, as the | |||||
* External: N | ||||||
* Path Required: Y | ||||||
|
||||||
## MLS Credential Types | ||||||
## MLS Credential Types {#iana-creds} | ||||||
|
||||||
### Extension Credential | ||||||
|
||||||
|
@@ -1398,6 +1498,20 @@ from a group more efficiently than using a `remove` proposal type, as the | |||||
* Recommended: Y | ||||||
* Reference: RFC XXXX | ||||||
|
||||||
### Multi Credential | ||||||
|
||||||
* Value: 0x0004 | ||||||
* Name: multi | ||||||
* Recommended: Y | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
* Reference: RFC XXXX | ||||||
|
||||||
### Weak Multi Credential | ||||||
|
||||||
* Value: 0x0005 | ||||||
* Name: weak-multi | ||||||
* Recommended: Y | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
* Reference: RFC XXXX | ||||||
|
||||||
## MLS Signature Labels | ||||||
|
||||||
### Labeled Extension Content | ||||||
|
@@ -1450,3 +1564,8 @@ completely validate a GroupInfo object that it receives. An insider | |||||
can prevent an External Join by providing either an invalid GroupInfo object | ||||||
or an invalid SelfRemove Proposal. The security properties of external joins | ||||||
does not change with the addition of this proposal type. | ||||||
|
||||||
## Multi Credentials | ||||||
|
||||||
Using a Weak Multi Credential reduces the overall credential security to the | ||||||
security of the least secure of its credential bindings. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would the ciphersuite not match? What is its purpose?