Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dpo #806

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Feature/dpo #806

wants to merge 36 commits into from

Conversation

pengwei715
Copy link
Contributor

Hi @guy1992l @ZeevRispler @yonishelach

I have followed your work of auto_trainer to implement the dpo trainer. Please review and let me know.

Thanks

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@ZeevRispler ZeevRispler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like most code is similar to the other training function, i belive there is a good way to make this a lot shorter

@@ -0,0 +1,23 @@
apiVersion: v1
categories:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yonishelach please advise what category to add for GenAI.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add these exact categories:

  • genai
  • huggingface
  • NLP

@@ -0,0 +1,23 @@
apiVersion: v1
categories:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add these exact categories:

  • genai
  • huggingface
  • NLP

@yonishelach
Copy link
Collaborator

@pengwei715 also your CI test is failing, so need to resolve this issue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants