-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dpo #806
base: master
Are you sure you want to change the base?
Feature/dpo #806
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like most code is similar to the other training function, i belive there is a good way to make this a lot shorter
@@ -0,0 +1,23 @@ | |||
apiVersion: v1 | |||
categories: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yonishelach please advise what category to add for GenAI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add these exact categories:
genai
huggingface
NLP
@@ -0,0 +1,23 @@ | |||
apiVersion: v1 | |||
categories: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add these exact categories:
genai
huggingface
NLP
@pengwei715 also your CI test is failing, so need to resolve this issue as well |
Hi @guy1992l @ZeevRispler @yonishelach
I have followed your work of auto_trainer to implement the dpo trainer. Please review and let me know.
Thanks