-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Survival learner doc updates + miscellaneous stuff #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebffischer
reviewed
Oct 15, 2024
sebffischer
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great, just some minor comments / questions
sebffischer
approved these changes
Oct 18, 2024
This was referenced Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes
@section
for allsurvival
learners, making sure it is well documented and consistent Refine prediction type doc for survival learners #347crank
as main prediction (and it is always returned) Set defaultpredict_type = crank
for all survival learners #331n_thread = 1
forsurv.aorsf
and use unique event time points for predictedS(t)
@bcjaegerselected_features()
forsurv.penalized
surv.prioritylasso
learner + adddistr
predictions via Breslow Survival Priority Lasso Update #344gamma.mu
was splitted togamma
andmu
distr
) #387parametric
andakritas
get a properntime
argumentparametric
is now used by default withdiscrete = TRUE
List of survival learners (WIP)