Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use %in% in BenchmarkAggr$subset() rather than == #38

Closed
wants to merge 1 commit into from

Conversation

jemus42
Copy link
Member

@jemus42 jemus42 commented Jan 19, 2024

I found that $subset() threw a warning if learner or task was a character length greater 1.
While I wasn't able to create a simple regex to reproduce it, I don't see any downside to using %in% here though, which appears to work just fine in my case.

@jemus42
Copy link
Member Author

jemus42 commented Jan 19, 2024

Ah nevermind, I see that #36 also addresses this while also changing other parts of the class.

@jemus42 jemus42 closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant