New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue a warning if `blocking` was set in the Task but `blocking.cv` was not set within `makeResampleDesc()` #2788

Merged

pat-s merged 2 commits into master from issue-blocking-warning

Sep 23, 2020

Member

pat-s commented Sep 20, 2020

fixes #2787

@mllg I'd argue that this is the most lightweight fix here.


          - issue a warning if blocking was set in the Task but blocking.cv…

855463f

… was not set within `makeResampleDesc()`

pat-s requested a review from mllg

September 20, 2020 07:16

mllg approved these changes

View reviewed changes


          update condition for blocking.cv warning

a74e582

pat-s merged commit 068ac9b into master

pat-s deleted the issue-blocking-warning branch

September 23, 2020 07:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet