Fix xgboost label inv in binary settings #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @mllg |
mllg
requested changes
Oct 7, 2019
| @@ -63,9 +63,10 @@ trainLearner.classif.xgboost = function(.learner, .task, .subset, .weights = NUL | |||
| td = getTaskDesc(.task) | |||
| parlist = list(...) | |||
| nc = length(td$class.levels) | |||
| nlvls = length(td$class.levels) | |||
| @@ -79,6 +80,10 @@ trainLearner.classif.xgboost = function(.learner, .task, .subset, .weights = NUL | |||
|
|
|||
| task.data = getTaskData(.task, .subset, target.extra = TRUE) | |||
| label = match(as.character(task.data$target), td$class.levels) - 1 | |||
|
|
|||
| # recode to 0:1 to that for the binary case the positive class translates to 1 (https://github.com/mlr-org/mlr3learners/issues/32) | |||
| # task.data$target is guaranteed to have the factor levels in the right order | |||
There was a problem hiding this comment.
have you doubled checked that this holds for mlr?
There was a problem hiding this comment.
Yes. Also the tests should ensure this.
|
The error we're getting in the tests is really weird. I see no change that would affect a change of probs in the following way: ── 1. Failure: classif_xgboost (@test_classif_xgboost.R#58) ───────────────────
`p` not equal to `old.probs`.
87/107 mismatches (average diff: 2.98e-08)
[1] 0.371 - 0.371 == 2.98e-08
[2] 0.371 - 0.371 == 2.98e-08
[3] 0.371 - 0.371 == 2.98e-08
[4] 0.371 - 0.371 == 2.98e-08
[5] 0.371 - 0.371 == 2.98e-08
[6] 0.371 - 0.371 == 2.98e-08
[7] 0.371 - 0.371 == 2.98e-08
[8] 0.371 - 0.371 == 2.98e-08
[9] 0.371 - 0.371 == 2.98e-08Would you mind taking a look? Thanks. |
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
* fix xgboost inv label issue * upd NEWS * revert regrLearner * add tolerance value for test * Deploy from Travis build 14334 [ci skip] Build URL: https://travis-ci.org/mlr-org/mlr/builds/603356026 Commit: 00731c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mlr-org/mlr3learners#32
cc @001ben