Expanded functionality for regr.h2o.gbm #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 17, 2018 11:35
|
Thanks, looks good. Could you add a few of those new parameters in the test please so that they're checked automatically? |
Added! I'm not sure what I can do about the appveyor build failing, any suggestions? |
|
Appveyor build is not stable atm, merging a PR soon. Just ignore if for now. |
|
Will take a closer look in the next days, please ping if not ;) |
pat-s
approved these changes
Feb 25, 2019
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
This pull request implements the suggestions in mlr-org#2208 for `regr.h2o.gbm` and elaborates on the available parameters. In particular, it removes the decision to hard code `distribution = "gaussian"` from the learner and allows the use of others. <!--- We are always happy to receive pull requests. Please make sure you have read our coding guidelines: https://github.com/mlr-org/mlr/wiki/mlr-Coding-Guidelines This especially means that you have understood: * The style guide - our lintr will provide you feedback on this * How to run tests locally. Yes, travis will also run them for you, bad it is annoying to wait for this. * How to run R CMD CHECK locally. See point before. Also it's helpful to get into direct contact with the suggested reviewers to get help, getting your PR merged. You might want to join our slack at: https://mlr-org.slack.com --->
vrodriguezf
pushed a commit
to vrodriguezf/mlr
that referenced
this pull request
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the suggestions in #2208 for
regr.h2o.gbmand elaborates on the available parameters.In particular, it removes the decision to hard code
distribution = "gaussian"from the learner and allows the use of others.