Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for missings in newdata #2068

Closed
wants to merge 2 commits into from
Closed

Conversation

QuayAu
Copy link
Contributor

@QuayAu QuayAu commented Nov 28, 2017

Fix for #1515

@mb706
Copy link
Contributor

mb706 commented Nov 28, 2017

Usually the prediction made for one row of data should not depend on predictions made for other data rows, or be even dependent on the presence or absence of other data rows. I would suggest to extend this logic here: Don't throw an error if NAs are present, and instead predict NAs for the rows that contain NAs.

In practice, if a Learner does not support NAs:

  1. Remove data rows that contain NAs from input data
  2. Perform prediction on this reduced data set
  3. Insert NAs in the predictions returned by the Learner at the position of rows that were remove in 1.

@pat-s
Copy link
Member

pat-s commented Jun 6, 2019

Superseeded by #2099

@pat-s pat-s closed this Jun 6, 2019
@pat-s pat-s deleted the fix.iss1515.NA.testset branch June 6, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants