Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resample printer makes tuneParams printer ugly. #1963

Closed
ja-thomas opened this issue Aug 4, 2017 · 4 comments
Closed

new resample printer makes tuneParams printer ugly. #1963

ja-thomas opened this issue Aug 4, 2017 · 4 comments

Comments

@ja-thomas
Copy link
Contributor

library(devtools)
load_all()
configureMlr(show.info = TRUE)

ps = makeParamSet(
  makeNumericParam("C", lower = 0.01, upper = 0.1)
)

ctrl = makeTuneControlRandom(maxit = 5L)
rdesc = makeResampleDesc("CV", iters = 3L)
measure = acc
discrete_ps = makeParamSet(
  makeDiscreteParam("C", values = c(0.5, 1.0, 1.5, 2.0)),
  makeDiscreteParam("sigma", values = c(0.5, 1.0, 1.5, 2.0))
)
res = tuneParams("classif.ksvm", task = iris.task, resampling = rdesc,
  par.set = discrete_ps, control = ctrl)

[Tune] Started tuning learner classif.ksvm for parameter set:
          Type len Def      Constr Req Tunable Trafo
C     discrete   -   - 0.5,1,1.5,2   -    TRUE     -
sigma discrete   -   - 0.5,1,1.5,2   -    TRUE     -
With control class: TuneControlRandom
Imputation value: 1
[Tune-x] 1: C=2; sigma=0.5
Resampling: cross-validation
Measures:             mmce      
[Tune-y] 1: mmce.test.mean=0.0533333; time: 0.0 min
[Tune-x] 2: C=2; sigma=1.5
Resampling: cross-validation
Measures:             mmce      
[Tune-y] 2: mmce.test.mean=0.0733333; time: 0.0 min
[Tune-x] 3: C=1.5; sigma=1
Resampling: cross-validation
Measures:             mmce      
[Tune-y] 3: mmce.test.mean=0.0666667; time: 0.0 min
[Tune-x] 4: C=0.5; sigma=0.5
Resampling: cross-validation
Measures:             mmce      
[Tune-y] 4: mmce.test.mean=0.0533333; time: 0.0 min
[Tune-x] 5: C=1; sigma=1
Resampling: cross-validation
Measures:             mmce      
[Tune-y] 5: mmce.test.mean=0.0666667; time: 0.0 min
[Tune] Result: C=2; sigma=0.5 : mmce.test.mean=0.0533333

And it ignores show.info

> configureMlr(show.info = FALSE)
> res = tuneParams("classif.ksvm", task = iris.task, resampling = rdesc,
+   par.set = discrete_ps, control = ctrl)
Resampling: cross-validation
Measures:             mmce      
Resampling: cross-validation
Measures:             mmce      
Resampling: cross-validation
Measures:             mmce      
Resampling: cross-validation
Measures:             mmce      
Resampling: cross-validation
Measures:             mmce      
@mb706
Copy link
Contributor

mb706 commented Aug 6, 2017

Some of the resample output ignores show.info now m(

@berndbischl
Copy link
Member

@larskotthoff
there are mutiple problem with this now. in the merge of the PR you said we should direct abuse your way...

did you check that the PR really works? by running stuff and looking at it?

@berndbischl
Copy link
Member

this needs to be fixed ASAP as it breaks mlr core

@larskotthoff
Copy link
Member

Fixed in #1974. Please check and merge.

@jakob-r jakob-r closed this as completed in 3a320a3 Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants