Fix task data (#2107)

* Fixing surv task data files for problem #2010 * renewing tasks that differed from what changeData() gives * test for changed data format
mlr-org · Dec 19, 2017 · 728657f · 728657f
1 parent 37f38b4
commit 728657f
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 0 deletions.
diff --git a/data/bc.task.spatial.rda b/data/bc.task.spatial.rda
diff --git a/data/costiris.task.rda b/data/costiris.task.rda
diff --git a/data/gunpoint.task.rda b/data/gunpoint.task.rda
diff --git a/data/lung.task.rda b/data/lung.task.rda
diff --git a/data/phoneme.task.rda b/data/phoneme.task.rda
diff --git a/data/wpbc.task.rda b/data/wpbc.task.rda
diff --git a/data/yeast.task.rda b/data/yeast.task.rda
diff --git a/tests/testthat/test_base_checkData.R b/tests/testthat/test_base_checkData.R
@@ -46,3 +46,16 @@ test_that("checkData", {
   colnames(df)[1] = "aaa"
   expect_error(makeClassifTask(data = df, target = multiclass.target), "Unsupported feature type")
 })
+
+test_that("changeData . getTaskData is a noop on builtin tasks", {
+  # We expect changeData(task, getTaskData(task, ...)) to not change task.
+  # If it does, it means that the internal format of task or task.desc has
+  # changed, and that the data needs to be re-generated.
+  pkgdata = data(package = "mlr")$results[, "Item"]
+  tasknames = grep("\\.task$", pkgdata, value = TRUE)
+  for (task in tasknames) {
+    taskdata = get(task)
+    changeddata = changeData(taskdata, getTaskData(taskdata, functionals.as = "matrix"))
+    expect_equal(taskdata, changeddata)
+  }
+})