Better FilterTree checkbox handling #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit mode has assumptions about the selection mode which are hard to overcome, and, potentially, may cause other issues. This CL changes toggle handling to a solution that just tracks clicks on checkboxes. There is an extra layout to determine where checkbox is, but it should be fast and only happen for the filter being toggled - not that editor solution is free from this as well. Another crucial piece is to use mutable tree nodes in the tree model. The selection handling keeps track of some TreePath instances and doesn't update them when the underlying model changes. Immutable filter instances were part of these TreePath, so enabling/disabling the filter (which replaces the immutable instance in the model) rendered these paths invalid, breaking selection tracking. Issue: fixes #384, fixes #385, fixes #386
Before we were only checking the position when releasing the button. Issue: n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #384, fixes #385, fixes #386