Search presenter #298
Merged
Search presenter #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit decouples the search implementation from the JTable and LogRecord, preparing it to be reused in other screens. More code is covered with tests. Issue: #297
This reduces the knowledge about MainFrame being spread everywhere. Issue: #297
As there's nobody to bootstrap the SourceStatusPresenter, this responsibility had to be passed to StatusPanel class.
The accelerators of the main menu work out of the box, so no additional binding is necessary. The only key that requires the binding is the Enter key in the search prompt that commits the pattern. MainFrameSearchPromptView takes care of setting this up instead of MainFrame. Issue: #297
Menu accelerators are slow. If the user presses and holds F3, the selection moves very slow. Having an explicit keybinding resolves the issue. The menu items are still here to serve as a documentation. Issue: #297
mlopatkin
force-pushed
the
ml/297/search-presenter
branch
from
731f9d5 to
c51f3d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of issue #297.