Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "About" dialog #364

Closed
mlopatkin opened this issue Jan 6, 2024 · 2 comments
Closed

Show "About" dialog #364

mlopatkin opened this issue Jan 6, 2024 · 2 comments
Assignees
Labels
a:enhancement New feature or request in:gui Tweaking GUI, implementing new UI
Milestone

Comments

@mlopatkin
Copy link
Owner

There is no About dialog, but it is a great place to put third-party licenses and other attribution.

@mlopatkin mlopatkin added a:enhancement New feature or request in:gui Tweaking GUI, implementing new UI labels Jan 6, 2024
@mlopatkin mlopatkin added this to the 0.24 milestone Jan 12, 2025
@mlopatkin mlopatkin self-assigned this Feb 2, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
This looks better because notices are typically small.

Issue: #364
mlopatkin added a commit that referenced this issue Feb 9, 2025
Changing a file used as a license source wasn't triggering a rebuild

Issue: #364
mlopatkin added a commit that referenced this issue Feb 9, 2025
This doesn't work well. I only have one source dependency that
originates from something with GAV, and there is no place were it fits
naturally anyway.

Issue: #364
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
So far this only applies to the icon, which is a combination of three
works.

Issue: #364
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
Of course, free icon catalogs are not serving them right.

Issue: #364
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
It is important for source licenses, because their notices do not make
sense otherwise.

Issue: #364
mlopatkin added a commit that referenced this issue Feb 9, 2025
It doesn't look good, the columns are of uneven width and there is no
clear visual separation between two.

Issue: #364
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
mlopatkin added a commit that referenced this issue Feb 9, 2025
Use the license files from the bundled JAVA_HOME for that.

Issue: #364

Fetch JRE information from the java home instead of separate JSON

Issue: #364
mlopatkin added a commit that referenced this issue Feb 9, 2025
The JDK licenses have some very long strings, causing the window to
scroll horizontally.

Issue: #364
@mlopatkin
Copy link
Owner Author

Need to also integrate it with app menu on macOS.

@mlopatkin
Copy link
Owner Author

The app menu can only be configured on Java 9+. Let's tweak it separately in #464.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:enhancement New feature or request in:gui Tweaking GUI, implementing new UI
Projects
None yet
Development

No branches or pull requests

1 participant