Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload ADB on the fly when the path to the executable changes #197

Closed
mlopatkin opened this issue Jan 6, 2022 · 0 comments · Fixed by #331
Closed

Reload ADB on the fly when the path to the executable changes #197

mlopatkin opened this issue Jan 6, 2022 · 0 comments · Fixed by #331
Assignees
@mlopatkin
Labels
a:enhancement New feature or request in:adb interaction with ADB
Milestone
0.22

Comments

@mlopatkin
Copy link
Owner

Currently the app asks the user to restart itself when the user changes the ADB path. This is inconvenient to say the least. Let's try to fix this, all pieces should be there already.
@mlopatkin mlopatkin added the a:enhancement New feature or request label Jan 6, 2022
@mlopatkin mlopatkin added this to the 0.22 milestone Jan 6, 2022
@mlopatkin mlopatkin added the in:adb interaction with ADB label Jan 9, 2022
@mlopatkin mlopatkin self-assigned this Nov 13, 2023
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Simplify AdbServerImpl lifecycle
69fff38 
It no longer attempts to handle service restarts.

Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Disconnect devices when the ADB server is stopped
f6b2109 
Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Correct AdbServerImpl's implementation comments
06bcf56 
Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Make the AdbDeviceList global instead of per-server instance
9c7c4a7 
This is mostly to make sure AdbOpener can survive server instance
changes without much hassle.

Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Use AdbServicesStatus to control ADB menu enabled/disabled state
b05169d 
It is better suited for handling status changes that are not triggered
by any kind of loading.

Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Make waitForDevice mode survive adb failures and restarts
244b100 
Prior to this commit, AdbDeviceList could only be obtained after ADB
initialization. However, the GlobalAdbDeviceList is already
independent of the ADB connection, it can be initialized without one and
get the connection later. Allowing to obtain the list without wait
greatly simplified the AdbOpener's wait-for-device flow, and made it
resilient to the adb failure. This is an important step to handle ADB
restarts properly.

As part of the implementation, AdbDataSourceFactory doesn't require ADB
to be obtained as well.

Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Add method to discard current ADB services
4e021d8 
The connection can then be re-established

Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Restart ADB if the path to its executable is changed by the user
d5cfa8c 
Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Force start ADB even if the path not changed if it failed to initialize
a1d874b 
This gives an option for the user to restart a failed ADB connection
without restarting the whole app.

Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Suppress disconnect warning dialog until adb restart completes
723290c 
Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Update release notes
ffdaa1e 
Issue: #197
@mlopatkin mlopatkin mentioned this issue Dec 25, 2023
Merged
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Suppress disconnect warning dialog until adb restart completes
19534a1 
Issue: #197
mlopatkin added a commit that referenced this issue Dec 25, 2023
@mlopatkin
Update release notes
9d3ea2e 
Issue: #197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlopatkin mlopatkin

Labels
a:enhancement New feature or request in:adb interaction with ADB
Projects
None yet
Milestone
0.22
Development

Successfully merging a pull request may close this issue.

Reload adb on the fly mlopatkin/andlogview
1 participant
@mlopatkin