Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEL key doesn't delete a bookmark in bookmarks window #149

Closed
mlopatkin opened this issue Mar 24, 2020 · 0 comments · Fixed by #349
Closed

DEL key doesn't delete a bookmark in bookmarks window #149

mlopatkin opened this issue Mar 24, 2020 · 0 comments · Fixed by #349
Labels
a:regression This used to work, but doesn't affects-version:0.19 good first issue Good for newcomers help wanted Extra attention is needed in:bookmarks Log bookmarks
Milestone
0.22

Comments

@mlopatkin
Copy link
Owner

Original report by me.

  1. Add bookmark
  2. Open bookmarks window
  3. Select added bookmark
  4. Press DEL key

Expected result: bookmark deleted

Actual result: nothing happens

‌

This is a regression in 0.19
@mlopatkin mlopatkin self-assigned this Dec 13, 2021
@mlopatkin mlopatkin added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 8, 2022
@mlopatkin mlopatkin modified the milestones: 0.21, 0.22 Jan 9, 2022
@mlopatkin mlopatkin added the in:bookmarks Log bookmarks label Jan 9, 2022
@mlopatkin mlopatkin removed their assignment Sep 29, 2022
@mlopatkin mlopatkin added a:regression This used to work, but doesn't and removed a:bug Something isn't working labels Dec 26, 2023
mlopatkin added a commit that referenced this issue Jan 2, 2024
@mlopatkin
Delete selected bookmarks on DEL button press
fef16db 
The wiring is messy, but I need a consistent way of managing these
shortcuts first. Then I'll rewrite

Issue: #149
@mlopatkin mlopatkin mentioned this issue Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:regression This used to work, but doesn't affects-version:0.19 good first issue Good for newcomers help wanted Extra attention is needed in:bookmarks Log bookmarks
Projects
None yet
Milestone
0.22
Development

Successfully merging a pull request may close this issue.

Delete selected bookmarks on DEL button press mlopatkin/andlogview
1 participant
@mlopatkin