-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare v0.3.0 release #98
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small typo, then all good to go 😄
In setting things up on Gefion I just noticed that neural-lam doesn't currently expose its own version. It is common to use the import neural_lam
print(neural_lam.__version__) Since we use import importlib.metadata
try:
__version__ = importlib.metadata.version(__name__)
except importlib.metadata.PackageNotFoundError:
__version__ = "unknown" The exception handling is for when the package is a local copy or hasn't been installed with setuptools (i.e. pip or pdm install). Xarray uses the same approch https://github.com/pydata/xarray/blob/main/xarray/__init__.py#L60 Would you be ok with me including this in this PR? It would help our tracking of what is installed when using neural-lam on Gefion |
Yes, that would be good to add. I am ok with you just adding that in this PR. |
Co-authored-by: Joel Oskarsson <[email protected]>
Co-authored-by: Joel Oskarsson <[email protected]>
Describe your changes
Updates CHANGELOG and pyproject.toml to reference the new
v0.3.0
release that will be tagged shortly.Issue Link
No issue
Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee