add package build and upload to pypi for releases into ci/cd setup #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add ci/cd setup to build and upload releases created on github automatically to pypi.org
This would allow people to install releases of
neural_lam
directly withpip
frompypi.org
, i.e. to install releases ofneural_lam
with:I could also include a note in the README about being able to install releases of
neural-lam
from pypi, but I haven't yet.The change requires a pypi.org API key be added to the repository secrets (you can see its use here: https://github.com/mllam/neural-lam/pull/71/files#diff-8edc26411310cfa4356b22a2f31845a08e57cb9f418b3b802f0366a2630af992R22). I have create an API token under my pypi.org user, but I will transfer this to a group on pypi.org when the first package has been uploaded, and people can then join that group on pypi.org.
Issue Link
There is no issue to link to. We haven't discussed this before I don't think. But I thought it might make sense and be convenient since with #37 and #32 it is now possible to install
neural-lam
as a package.Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee