Contributions to #34 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and removes need for pyproj
|
@sadamov please have a look. |
sadamov
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Thanks a lot @TomasLandelius for your work on this and your patience while I was traveling. I do agree that having simpler solutions that are still robust but faster make a lot of sense for our usecase. I ran your code and it works great.
I will merge this PR and we should discuss with @leifdenby and the Dev-Team how we want to add these forcing calculations to the roadmap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added alternative functions for calculation of toa irradiance and border masks using similar input and output as in the existing ones. Also removed need for pyproj by reformulating projections using cartopy.