Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call validation split 'val' instead of 'validation' in example config #28

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

ealerskans
Copy link
Contributor

The new datastores functionality in neural-lam mllam/neural-lam#66 assumes that the validation split is called val rather than validation.

With this addition, the example config in mllam-data-prep uses val instead of validation to be consistent with that, as proposed in #24.

@observingClouds
Copy link
Contributor

@ealerskans could you change also the examples in the README.md? I guess quite some folks might copy the example directly from there.

Copy link
Contributor

@observingClouds observingClouds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@observingClouds observingClouds merged commit 534bbc8 into mllam:main Oct 30, 2024
5 checks passed
@leifdenby
Copy link
Member

Thanks for doing this @ealerskans and @observingClouds !

@ealerskans ealerskans deleted the update-example-config branch November 7, 2024 10:25
@leifdenby leifdenby mentioned this pull request Nov 18, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants