-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add section for extra info in config #18
add section for extra info in config #18
Conversation
Just FIY I have decided that this hacky approach (where an |
I am reopening this because it is turning out to be currently impossible to add proper WKT-string based projection info to the config and have that parsed and used in I do need to fix that the example I am showing with DANRA had the wrong default globe (as in correct default radius for the globe) relative to what is assumed in DANRA. I.e. the example in the config of this PR results in the projection being
Which has the incorrect (default) globe radius. whereas it should be (thank you @SimonKamuk!): cartopy.crs.LambertConformal(
central_latitude=56.7, central_longitude=25, standard_parallels=(56.7,56.7),
globe=cartopy.crs.Globe(semimajor_axis=6367470, semiminor_axis=6367470)
) |
…feat/extra-section-in-config
Ok, this is ready for review now @observingClouds 🎁 I added some rudimentary functionality to enable support of multiple schema versions and also wrote up my current plans for schema versioning in the bottom of the README. For now I suggest we inline in the code with comments simply keep track of what schema versions the current version of Hope this makes sense! PS. I noticed when #35 and #36 were merged in that the changelog entry went in the wrong place for the former and there's no changelog entry for the latter. But I will clean that up when I prepare the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the only issue that I see before this can be merged is the correct projection information....once again...
Thanks for all the help @observingClouds and @SimonKamuk! I am merging this in 😄 |
Add section called
extra
in config which is ignored bymllam-data-prep
but can be used to add any extra info the user might want to keep track of. The intention is that this will be used in neural-lam to keep of projection information for now at least