fix: Set attestation as false in pypi release #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Abbas Jaffri <[email protected]>
webknjaz
reviewed
Nov 26, 2024
| @@ -91,3 +91,5 @@ jobs: | |||
| repository-url: https://test.pypi.org/legacy/ | |||
| - name: Publish distribution 📦 to PyPI | |||
| uses: pypa/gh-action-pypi-publish@release/v1 | |||
| with: | |||
| attestations: false | |||
There was a problem hiding this comment.
this is a bad idea. at least move it to testpypi
There was a problem hiding this comment.
I had to set attestations as false as it was failing for release to pypi. But can you elaborate on your comment a bit more, as to why its not a good idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes the following changes
PR Checklist
PR Type
What kind of change does this PR introduce?