Use sanity_checking instead of running_sanity_check in pytorch-lightning > 1.4.5
#4767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harupy <[email protected]>
BenWilson2
pushed a commit
that referenced
this pull request
Sep 7, 2021
Signed-off-by: harupy <[email protected]> Signed-off-by: benwilson <[email protected]>
BenWilson2
added a commit
that referenced
this pull request
Sep 10, 2021
* WIP build Signed-off-by: benwilson <[email protected]> * Finish unit tests and address prophet build dependencies for serving Signed-off-by: benwilson <[email protected]> * refactor example for prophet and add tracking validation test Signed-off-by: benwilson <[email protected]> * adjusting build env Signed-off-by: benwilson <[email protected]> * linting Signed-off-by: benwilson <[email protected]> * Increase HTTP timeout to 90s. Disabled cloud storage HTTP timeout. (#4764) * Increase HTTP timeout to 120s. Disabled cloud storage HTTP timeout. * Enable auto dependency inference in spark flavor (#4759) * use infer_pip_requirements to spark.py Signed-off-by: harupy <[email protected]> * fix tests Signed-off-by: harupy <[email protected]> * fix tests Signed-off-by: harupy <[email protected]> * rename test Signed-off-by: harupy <[email protected]> * workaround for databricks Signed-off-by: harupy <[email protected]> * workaround for pyspark in databricks Signed-off-by: harupy <[email protected]> * rename test Signed-off-by: harupy <[email protected]> * address comments Signed-off-by: harupy <[email protected]> * better error message Signed-off-by: harupy <[email protected]> * fix error message Signed-off-by: harupy <[email protected]> * Fix `test_autolog_emits_warning_message_when_model_prediction_fails` (#4768) * Use AttributeError Signed-off-by: harupy <[email protected]> * comment Signed-off-by: harupy <[email protected]> * fix Signed-off-by: harupy <[email protected]> * use sanity_checking (#4767) Signed-off-by: harupy <[email protected]> * refactor: Extract the docker image building _build_image_from_context function (#4769) * refactor: Extract the docker image building _build_image_from_context function Signed-off-by: Alexey Volkov <[email protected]> * blacken Signed-off-by: harupy <[email protected]> Co-authored-by: harupy <[email protected]> * Fix autologging compatibility with Keras >= 2.6.0 (#4766) * Increase HTTP timeout to 90s. Disabled cloud storage HTTP timeout. (#4764) * Increase HTTP timeout to 120s. Disabled cloud storage HTTP timeout. Signed-off-by: dbczumar <[email protected]> * Include keras conditionally Signed-off-by: dbczumar <[email protected]> * Fixes Signed-off-by: dbczumar <[email protected]> * Fix Signed-off-by: dbczumar <[email protected]> * Fix root cause Signed-off-by: dbczumar <[email protected]> * docstring Signed-off-by: dbczumar <[email protected]> * Some test cases Signed-off-by: dbczumar <[email protected]> * Some test cases Signed-off-by: dbczumar <[email protected]> * Tests Signed-off-by: dbczumar <[email protected]> * Format Signed-off-by: dbczumar <[email protected]> * Test fixes Signed-off-by: dbczumar <[email protected]> * Test fix 2 Signed-off-by: dbczumar <[email protected]> * Remove keras change Signed-off-by: dbczumar <[email protected]> * Use is Signed-off-by: dbczumar <[email protected]> * Remove unused modules Signed-off-by: dbczumar <[email protected]> * Use fixtures Signed-off-by: dbczumar <[email protected]> * Docstring Signed-off-by: dbczumar <[email protected]> * Fix fixtures Signed-off-by: dbczumar <[email protected]> * Lint fixes Signed-off-by: dbczumar <[email protected]> * Format Signed-off-by: dbczumar <[email protected]> * Try preserve find module Signed-off-by: dbczumar <[email protected]> * fix Signed-off-by: Weichen Xu <[email protected]> * fix2 Signed-off-by: Weichen Xu <[email protected]> * Simplify fluent test cases Signed-off-by: dbczumar <[email protected]> * Format Signed-off-by: dbczumar <[email protected]> * Tweaks, add a warning Signed-off-by: dbczumar <[email protected]> * Test excludee Signed-off-by: dbczumar <[email protected]> * Reverts Signed-off-by: dbczumar <[email protected]> Co-authored-by: jinzhang21 <[email protected]> Co-authored-by: Weichen Xu <[email protected]> * Update spark support version to be 3.2 (#4770) * init Signed-off-by: Weichen Xu <[email protected]> * Fix set matrix Signed-off-by: dbczumar <[email protected]> * Fix Signed-off-by: dbczumar <[email protected]> * Format Signed-off-by: dbczumar <[email protected]> Co-authored-by: dbczumar <[email protected]> * merge * merge * fix build errors * Changelog message tweak (#4777) * Tweak Signed-off-by: dbczumar <[email protected]> * Lang Signed-off-by: dbczumar <[email protected]> * Update CHANGELOG.rst * [ALL TESTS] Update (#4778) * Update MLflow version to 1.20.3 Signed-off-by: Jenkins <[email protected]> * Update Signed-off-by: dbczumar <[email protected]> Co-authored-by: Jenkins <[email protected]> Co-authored-by: dbczumar <[email protected]> * Fix small typo (#4772) Before: ``` 2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: precision_score failed. The metric test_gold_precision_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str' 2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: recall_score failed. The metric test_gold_recall_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str' 2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: f1_score failed. The metric test_gold_f1_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str' 2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: accuracy_score failed. The metric test_gold_accuracy_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str' ``` Signed-off-by: Louis Guitton <[email protected]> * Push MLflow model to Sagemaker model registry (#4669) * Added push_sagemaker_model() api to enable push model from MLflow to Sagemaker model registry Signed-off-by: Jinni Gu <[email protected]> * Fixed the python doc for _find_transform_job() Signed-off-by: Jinni Gu <[email protected]> * Replace https protocol with s3:// protocol for the URL where Sagemaker model artifacts are stored in S3. Signed-off-by: Yiqing Wang <[email protected]> * rename push_sagemaker_model function add CLI function for push_model_to_sagemaker Signed-off-by: qtz123 <[email protected]> * reformat CLI for push_model_to_sagemaker Signed-off-by: qtz123 <[email protected]> * Used describe_model instead of list_models to check if the model exists. Signed-off-by: Yiqing Wang <[email protected]> * Renamed the _find_model method to _does_model_exist and limit the scope Signed-off-by: Yiqing Wang <[email protected]> * Fixed lint error and changed command to push model Signed-off-by: Yiqing Wang <[email protected]> Co-authored-by: Yiqing Wang <[email protected]> Co-authored-by: qtz123 <[email protected]> * Fix tensorflow dev cross test (#4780) * init Signed-off-by: Weichen Xu <[email protected]> * dummy tf update Signed-off-by: Weichen Xu <[email protected]> * Adding requirements for prophet examples Signed-off-by: Ben Wilson <[email protected]> * update conda versions for prophet Signed-off-by: Ben Wilson <[email protected]> * Fixing the prophet tests Signed-off-by: Ben Wilson <[email protected]> * PR fixes Signed-off-by: Ben Wilson <[email protected]> * Add notes on sub-dependencies Signed-off-by: Ben Wilson <[email protected]> * Updating docs for Prophet flavor Signed-off-by: Ben Wilson <[email protected]> * Resolve dependencies and add flavor tests Signed-off-by: Ben Wilson <[email protected]> * update conda.yaml in examples for prophet Signed-off-by: Ben Wilson <[email protected]> Co-authored-by: jinzhang21 <[email protected]> Co-authored-by: Harutaka Kawamura <[email protected]> Co-authored-by: Alexey Volkov <[email protected]> Co-authored-by: dbczumar <[email protected]> Co-authored-by: Weichen Xu <[email protected]> Co-authored-by: dbczumar <[email protected]> Co-authored-by: mlflow-automation <[email protected]> Co-authored-by: Jenkins <[email protected]> Co-authored-by: Louis Guitton <[email protected]> Co-authored-by: Jinni Gu <[email protected]> Co-authored-by: Yiqing Wang <[email protected]> Co-authored-by: qtz123 <[email protected]>
anjsam1402
pushed a commit
to anjsam1402/mlflow
that referenced
this pull request
Sep 14, 2021
* WIP build Signed-off-by: benwilson <[email protected]> * Finish unit tests and address prophet build dependencies for serving Signed-off-by: benwilson <[email protected]> * refactor example for prophet and add tracking validation test Signed-off-by: benwilson <[email protected]> * adjusting build env Signed-off-by: benwilson <[email protected]> * linting Signed-off-by: benwilson <[email protected]> * Increase HTTP timeout to 90s. Disabled cloud storage HTTP timeout. (mlflow#4764) * Increase HTTP timeout to 120s. Disabled cloud storage HTTP timeout. * Enable auto dependency inference in spark flavor (mlflow#4759) * use infer_pip_requirements to spark.py Signed-off-by: harupy <[email protected]> * fix tests Signed-off-by: harupy <[email protected]> * fix tests Signed-off-by: harupy <[email protected]> * rename test Signed-off-by: harupy <[email protected]> * workaround for databricks Signed-off-by: harupy <[email protected]> * workaround for pyspark in databricks Signed-off-by: harupy <[email protected]> * rename test Signed-off-by: harupy <[email protected]> * address comments Signed-off-by: harupy <[email protected]> * better error message Signed-off-by: harupy <[email protected]> * fix error message Signed-off-by: harupy <[email protected]> * Fix `test_autolog_emits_warning_message_when_model_prediction_fails` (mlflow#4768) * Use AttributeError Signed-off-by: harupy <[email protected]> * comment Signed-off-by: harupy <[email protected]> * fix Signed-off-by: harupy <[email protected]> * use sanity_checking (mlflow#4767) Signed-off-by: harupy <[email protected]> * refactor: Extract the docker image building _build_image_from_context function (mlflow#4769) * refactor: Extract the docker image building _build_image_from_context function Signed-off-by: Alexey Volkov <[email protected]> * blacken Signed-off-by: harupy <[email protected]> Co-authored-by: harupy <[email protected]> * Fix autologging compatibility with Keras >= 2.6.0 (mlflow#4766) * Increase HTTP timeout to 90s. Disabled cloud storage HTTP timeout. (mlflow#4764) * Increase HTTP timeout to 120s. Disabled cloud storage HTTP timeout. Signed-off-by: dbczumar <[email protected]> * Include keras conditionally Signed-off-by: dbczumar <[email protected]> * Fixes Signed-off-by: dbczumar <[email protected]> * Fix Signed-off-by: dbczumar <[email protected]> * Fix root cause Signed-off-by: dbczumar <[email protected]> * docstring Signed-off-by: dbczumar <[email protected]> * Some test cases Signed-off-by: dbczumar <[email protected]> * Some test cases Signed-off-by: dbczumar <[email protected]> * Tests Signed-off-by: dbczumar <[email protected]> * Format Signed-off-by: dbczumar <[email protected]> * Test fixes Signed-off-by: dbczumar <[email protected]> * Test fix 2 Signed-off-by: dbczumar <[email protected]> * Remove keras change Signed-off-by: dbczumar <[email protected]> * Use is Signed-off-by: dbczumar <[email protected]> * Remove unused modules Signed-off-by: dbczumar <[email protected]> * Use fixtures Signed-off-by: dbczumar <[email protected]> * Docstring Signed-off-by: dbczumar <[email protected]> * Fix fixtures Signed-off-by: dbczumar <[email protected]> * Lint fixes Signed-off-by: dbczumar <[email protected]> * Format Signed-off-by: dbczumar <[email protected]> * Try preserve find module Signed-off-by: dbczumar <[email protected]> * fix Signed-off-by: Weichen Xu <[email protected]> * fix2 Signed-off-by: Weichen Xu <[email protected]> * Simplify fluent test cases Signed-off-by: dbczumar <[email protected]> * Format Signed-off-by: dbczumar <[email protected]> * Tweaks, add a warning Signed-off-by: dbczumar <[email protected]> * Test excludee Signed-off-by: dbczumar <[email protected]> * Reverts Signed-off-by: dbczumar <[email protected]> Co-authored-by: jinzhang21 <[email protected]> Co-authored-by: Weichen Xu <[email protected]> * Update spark support version to be 3.2 (mlflow#4770) * init Signed-off-by: Weichen Xu <[email protected]> * Fix set matrix Signed-off-by: dbczumar <[email protected]> * Fix Signed-off-by: dbczumar <[email protected]> * Format Signed-off-by: dbczumar <[email protected]> Co-authored-by: dbczumar <[email protected]> * merge * merge * fix build errors * Changelog message tweak (mlflow#4777) * Tweak Signed-off-by: dbczumar <[email protected]> * Lang Signed-off-by: dbczumar <[email protected]> * Update CHANGELOG.rst * [ALL TESTS] Update (mlflow#4778) * Update MLflow version to 1.20.3 Signed-off-by: Jenkins <[email protected]> * Update Signed-off-by: dbczumar <[email protected]> Co-authored-by: Jenkins <[email protected]> Co-authored-by: dbczumar <[email protected]> * Fix small typo (mlflow#4772) Before: ``` 2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: precision_score failed. The metric test_gold_precision_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str' 2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: recall_score failed. The metric test_gold_recall_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str' 2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: f1_score failed. The metric test_gold_f1_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str' 2021/09/03 18:53:45 WARNING mlflow.sklearn.utils: accuracy_score failed. The metric test_gold_accuracy_scorewill not be recorded. Metric error: '<' not supported between instances of 'float' and 'str' ``` Signed-off-by: Louis Guitton <[email protected]> * Push MLflow model to Sagemaker model registry (mlflow#4669) * Added push_sagemaker_model() api to enable push model from MLflow to Sagemaker model registry Signed-off-by: Jinni Gu <[email protected]> * Fixed the python doc for _find_transform_job() Signed-off-by: Jinni Gu <[email protected]> * Replace https protocol with s3:// protocol for the URL where Sagemaker model artifacts are stored in S3. Signed-off-by: Yiqing Wang <[email protected]> * rename push_sagemaker_model function add CLI function for push_model_to_sagemaker Signed-off-by: qtz123 <[email protected]> * reformat CLI for push_model_to_sagemaker Signed-off-by: qtz123 <[email protected]> * Used describe_model instead of list_models to check if the model exists. Signed-off-by: Yiqing Wang <[email protected]> * Renamed the _find_model method to _does_model_exist and limit the scope Signed-off-by: Yiqing Wang <[email protected]> * Fixed lint error and changed command to push model Signed-off-by: Yiqing Wang <[email protected]> Co-authored-by: Yiqing Wang <[email protected]> Co-authored-by: qtz123 <[email protected]> * Fix tensorflow dev cross test (mlflow#4780) * init Signed-off-by: Weichen Xu <[email protected]> * dummy tf update Signed-off-by: Weichen Xu <[email protected]> * Adding requirements for prophet examples Signed-off-by: Ben Wilson <[email protected]> * update conda versions for prophet Signed-off-by: Ben Wilson <[email protected]> * Fixing the prophet tests Signed-off-by: Ben Wilson <[email protected]> * PR fixes Signed-off-by: Ben Wilson <[email protected]> * Add notes on sub-dependencies Signed-off-by: Ben Wilson <[email protected]> * Updating docs for Prophet flavor Signed-off-by: Ben Wilson <[email protected]> * Resolve dependencies and add flavor tests Signed-off-by: Ben Wilson <[email protected]> * update conda.yaml in examples for prophet Signed-off-by: Ben Wilson <[email protected]> Co-authored-by: jinzhang21 <[email protected]> Co-authored-by: Harutaka Kawamura <[email protected]> Co-authored-by: Alexey Volkov <[email protected]> Co-authored-by: dbczumar <[email protected]> Co-authored-by: Weichen Xu <[email protected]> Co-authored-by: dbczumar <[email protected]> Co-authored-by: mlflow-automation <[email protected]> Co-authored-by: Jenkins <[email protected]> Co-authored-by: Louis Guitton <[email protected]> Co-authored-by: Jinni Gu <[email protected]> Co-authored-by: Yiqing Wang <[email protected]> Co-authored-by: qtz123 <[email protected]> Signed-off-by: Anjali Samad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: harupy [email protected]
What changes are proposed in this pull request?
The
running_sanity_checkattribute of a trainer object has been renamed tosanity_checking:Lightning-AI/pytorch-lightning#9209
This change broke pytorch autlogging tests.
How is this patch tested?
Existing tests
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes