Add more integration icons to the website #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: B-Step62 <[email protected]>
Signed-off-by: B-Step62 <[email protected]>
Signed-off-by: B-Step62 <[email protected]>
Preview for b00ab22
|
Signed-off-by: B-Step62 <[email protected]>
Signed-off-by: B-Step62 <[email protected]>
Signed-off-by: B-Step62 <[email protected]>
TomeHirata
reviewed
Dec 13, 2024
| const ExpandableGrid = ({ items, defaultVisibleCount, renderItem }) => { | ||
| const [isExpanded, setIsExpanded] = useState(false); | ||
|
|
||
| const visibleItems = isExpanded ? items : items.slice(0, defaultVisibleCount); |
There was a problem hiding this comment.
nits: we could use useMemo here, but it is probably not necessary since this should be a lightweight app and this component won't be rendered for many times.
There was a problem hiding this comment.
yea lemme keep it simple here for now
TomeHirata
reviewed
Dec 13, 2024
| const visibleItems = isExpanded ? items : items.slice(0, defaultVisibleCount); | ||
|
|
||
| return ( | ||
| <div> |
There was a problem hiding this comment.
do we need this top level div?
There was a problem hiding this comment.
not really - can replace with <></>🙂
|
Looks good, will defer to others who are more familiar with the repo. |
Signed-off-by: B-Step62 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are only showing 12 libraries on website but we have much more integrations. Adding most of them with expand/collapse.