Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod Unread Count #1008

Merged
merged 8 commits into from
Apr 13, 2024
Merged

Mod Unread Count #1008

merged 8 commits into from
Apr 13, 2024

Conversation

EricBAndrews
Copy link
Member

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • If this PR alters the UI, I have attached pictures/videos
  • This PR addresses one or more open issues that were assigned to me:
    - Follow-up to Eric/mod inbox #1001

Pull Request Information

This PR adds moderator notifications to the unread tracker. It also performs some light refactoring, creating a single reusable UnreadCount struct with .read(), .unread(), .toggleRead() functions to avoid duplicating that logic. The UnreadTracker is now also responsible for fetching from the server.

Users can choose which notification types should factor into the badge count in settings.

When there are unread items in a different inbox tab, the dropdown indicator on the feed header is highlighted.

Screenshot 2024-04-12 at 10 11 00 PM Screenshot 2024-04-12 at 10 12 51 PM

@EricBAndrews EricBAndrews requested a review from a team as a code owner April 13, 2024 02:13
@EricBAndrews EricBAndrews requested review from WestonHanners and ShadowJonathan and removed request for a team April 13, 2024 02:13
@EricBAndrews EricBAndrews force-pushed the eric/mod-unread-count branch from ce61878 to cdfef45 Compare April 13, 2024 02:14
@EricBAndrews EricBAndrews enabled auto-merge (squash) April 13, 2024 16:28
@EricBAndrews EricBAndrews requested a review from Sjmarf April 13, 2024 16:28
Copy link
Member

@Sjmarf Sjmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@EricBAndrews EricBAndrews merged commit f7278f2 into dev Apr 13, 2024
4 checks passed
@EricBAndrews EricBAndrews deleted the eric/mod-unread-count branch April 13, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants