-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod Unread Count #1008
Merged
Merged
Mod Unread Count #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricBAndrews
requested review from
WestonHanners and
ShadowJonathan
and removed request for
a team
April 13, 2024 02:13
EricBAndrews
force-pushed
the
eric/mod-unread-count
branch
from
April 13, 2024 02:14
ce61878
to
cdfef45
Compare
Sjmarf
requested changes
Apr 13, 2024
Mlem/API/Requests/Moderation/GetReportCountRequest.swift.tmp.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Sjmarf <[email protected]>
Co-authored-by: Sjmarf <[email protected]>
Sjmarf
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
- Follow-up to Eric/mod inbox #1001
Pull Request Information
This PR adds moderator notifications to the unread tracker. It also performs some light refactoring, creating a single reusable
UnreadCount
struct with.read()
,.unread()
,.toggleRead()
functions to avoid duplicating that logic. TheUnreadTracker
is now also responsible for fetching from the server.Users can choose which notification types should factor into the badge count in settings.
When there are unread items in a different inbox tab, the dropdown indicator on the feed header is highlighted.