use tensorflow 2.8.0 and bazel 5.0.0 #268

freedomtan · 2022-03-15T23:19:18Z

Update tensorflow to 2.8.0 and specify bazel version in
.bazelverion so that if wrong bazel version is used and there
is no right version in the system, bazel will show instructions.

We should make sure all the vendor backends get matching performance numbers (#231) before we upgrade TensorFlow

bazelbuild/bazel#145 bazelbuild/bazel#241

github-actions · 2022-03-15T23:19:38Z

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

freedomtan · 2022-03-16T02:22:05Z

the error messages of failed to build iOS Flutter app provide a good example how how the .bazelversion works

...
�[31mERROR: The project you're trying to build requires Bazel 5.0.0 (specified in /Users/jenkins/jenkins-agent/workspace/mobile_app_open/PullRequest-ios-build/.bazelversion), but it wasn't found in /Users/jenkins/.bazel/bin.�[0m

Bazel binaries for all official releases can be downloaded from here:
  https://github.com/bazelbuild/bazel/releases

You can download the required version directly using this command:
  (cd "/Users/jenkins/.bazel/bin" && curl -fLO https://releases.bazel.build/5.0.0/release/bazel-5.0.0-darwin-x86_64 && chmod +x bazel-5.0.0-darwin-x86_64)
make: *** [flutter/ios/native] Error 1
Build step 'Execute shell' marked build as failure
....

d-uzlov · 2022-03-18T04:07:56Z

Are we going to completely drop support for older bazel versions?

freedomtan · 2022-03-18T05:02:18Z

TensorFlow is somewhat bazel version sensitive. When a major bazel version is used by TensorFlow, it may break building with older bazel.

freedomtan · 2022-03-29T03:40:45Z

There are two issues,

bazel 5.0 check Android NDK (because we have ndk entry in WORKSPACE), 5.0rc1: android_ndk_repository is fetched eagerly bazelbuild/rules_android_ndk#92
the output of ios_static_framework is in bazel-out/ (and with variable name) instead of bazel-bin/
on a macbook pro x86, it's bazel-out/applebin_ios-ios_arm64-opt-ST-82c2c37ad712/bin/flutter/cpp/flutter/ios_backend_fw_static.zip

freedomtan · 2022-03-31T13:11:47Z

There are two issues,

bazel 5.0 check Android NDK (because we have ndk entry in WORKSPACE), 5.0rc1: android_ndk_repository is fetched eagerly bazelbuild/bazel#14260

the output of ios_static_framework is in bazel-out/ (and with variable name) instead of bazel-bin/
on a macbook pro x86, it's bazel-out/applebin_ios-ios_arm64-opt-ST-82c2c37ad712/bin/flutter/cpp/flutter/ios_backend_fw_static.zip

I fixed the two issues.

AhmedTElthakeb · 2022-04-12T03:21:15Z

For samsung backend, matching performance numbers are seen using tensorflow 2.8.0 and bazel 5.0.0

.bazelrc

anhappdev · 2022-05-31T05:01:24Z

This PR also closes #145

freedomtan · 2022-05-31T05:11:52Z

@freedomtan to rebase this to resolve conflicts.

flutter/third_party/tf-eigen.patch

Update tensorflow to 2.8.0 and specify bazel version in `.bazelverion` so that if wrong bazel version is used and there is no right version in the system, bazel will show instructions

it doesn't work with bazel 5.0.0 on windows

use the script to cp the framework to a fixed place

freedomtan · 2022-06-01T07:56:25Z

I rebased the patch and added the memory leak patch for Core ML delegate.

d-uzlov · 2022-06-01T19:34:07Z

flutter/third_party/android/android_configure.bzl

+    if sdk_home:
+        sdk_rule = """
+    native.android_sdk_repository(
+        name="androidsdk",
+        path="{}",
+        build_tools_version="30.0.3",
+    )
+""".format(_escape_for_windows(sdk_home))


Currently Android SDK is not needed for bazel builds in our repo.
Bazel builds only the .so files which only require NDK.
SDK is required for APK build but that can be done on a separate machine.

I personally build Android libraries for the app in a Docker container or in WSL and I don't install Android SDK there.
But with this patch I get an error because SDK is missing.

I think it would be better to comment these lines or just disable the condition using something like if sdk_home and False

sounds right. will do it.

@d-uzlov are you sure that on windows this doesn't work? I added this to get around the Android SDK problem in bazel you mentioned on macOS. I met the Android SDK missing problem when I tried to build this on macOS. It should work on Windows also. I mean if $ANDROID_HOME is not, sdk_home should not be set.

There are no issues building supported targets on Windows.
I don't have android-related environment variables defined on Windows, and bazel doesn't try to load them.

The issue is in the WSL virtual machine.
ANDROID_HOME is defined there because some of the Android tools are installed, also NDK is installed there, but the there is no actual SDK because it's not needed.

argh, got it, thanks. let me check how to handle this on Linux

@d-uzlov Could elaborate more on why we need ANDROID_HOME. I was able to build and run flutter app for Android devices on Ubuntu without ANDROID_HOME set.

We don't need it to build native libraries. And Android SDK is not required.
But if ANDROID_HOME is defined for whatever reason then Android SDK becomes required, even though it's not used by bazel.

I don't think requiring users not to have ANDROID_HOME is reasonable.

Let's merge it and I remove unused dependencies in a separate PR.

freedomtan · 2022-06-02T03:02:07Z

To build with TensorFlow 2.9.x, we need

-std=c++17,
extra dependency for //flutter/cpp:util, and
couple lines of changes to metal delegate source code (otherwise, it doesn't work properly on iPhone 13.)

I'll create another branch for 2.9.x.

freedomtan · 2022-06-02T04:48:43Z

A TensorFlow 2.9.1 branch based on this 2.8.0 one, https://github.com/mlcommons/mobile_app_open/tree/use_tensorflow_291.

And comparing with 2.8.0, #334

anhappdev · 2022-06-04T06:23:43Z

App built with XCode 13.4 run all benchmarks successfully on iPhone XS. Great work @freedomtan 👍.

freedomtan force-pushed the use_tensorflow_280 branch from 08ab532 to 1f6828b Compare March 31, 2022 00:15

d-uzlov mentioned this pull request Apr 29, 2022

Merge submission v2.0 into master #292

Merged

d-uzlov reviewed May 30, 2022

View reviewed changes

.bazelrc Show resolved Hide resolved

d-uzlov reviewed May 31, 2022

View reviewed changes

flutter/third_party/tf-eigen.patch Show resolved Hide resolved

freedomtan added 6 commits June 1, 2022 11:34

use tensorflow 2.8.0 and bazel 5.0.0

3e80945

Update tensorflow to 2.8.0 and specify bazel version in `.bazelverion` so that if wrong bazel version is used and there is no right version in the system, bazel will show instructions

remove --experimental_no_product_name_out_symlink for bazel

82d10e8

it doesn't work with bazel 5.0.0 on windows

make ios backend uild w/ tensorflow 2.8.0

97e8e5f

android ndk and sdk workaround from gprc

328aeff

clean up and buildifier

375b30d

add use ipa_post_processor script

00cace8

use the script to cp the framework to a fixed place

freedomtan force-pushed the use_tensorflow_280 branch from d12ff5f to 00cace8 Compare June 1, 2022 07:10

porting back coreml delegate memory leak patch

ef59e1f

d-uzlov reviewed Jun 1, 2022

View reviewed changes

freedomtan mentioned this pull request Jun 2, 2022

Multiple problems building TFLite 2.9.1 tensorflow/tensorflow#56250

Closed

This was linked to issues Jun 2, 2022

The app is impossible to build on macOS Monterey #329

Closed

possible memory leak in iOS app #332

Closed

d-uzlov approved these changes Jun 6, 2022

View reviewed changes

freedomtan merged commit 4499a5d into master Jun 6, 2022

github-actions bot locked and limited conversation to collaborators Jun 6, 2022

anhappdev deleted the use_tensorflow_280 branch November 11, 2022 02:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use tensorflow 2.8.0 and bazel 5.0.0 #268

use tensorflow 2.8.0 and bazel 5.0.0 #268

freedomtan commented Mar 15, 2022

github-actions bot commented Mar 15, 2022 •

edited

Loading

freedomtan commented Mar 16, 2022

d-uzlov commented Mar 18, 2022

freedomtan commented Mar 18, 2022

freedomtan commented Mar 29, 2022 •

edited

Loading

freedomtan commented Mar 31, 2022

AhmedTElthakeb commented Apr 12, 2022

anhappdev commented May 31, 2022

freedomtan commented May 31, 2022

freedomtan commented Jun 1, 2022

d-uzlov Jun 1, 2022

freedomtan Jun 2, 2022

freedomtan Jun 2, 2022

d-uzlov Jun 2, 2022

freedomtan Jun 6, 2022

freedomtan Jun 6, 2022

d-uzlov Jun 6, 2022

d-uzlov Jun 6, 2022

freedomtan commented Jun 2, 2022

freedomtan commented Jun 2, 2022 •

edited

Loading

anhappdev commented Jun 4, 2022

use tensorflow 2.8.0 and bazel 5.0.0 #268

use tensorflow 2.8.0 and bazel 5.0.0 #268

Conversation

freedomtan commented Mar 15, 2022

github-actions bot commented Mar 15, 2022 • edited Loading

freedomtan commented Mar 16, 2022

d-uzlov commented Mar 18, 2022

freedomtan commented Mar 18, 2022

freedomtan commented Mar 29, 2022 • edited Loading

freedomtan commented Mar 31, 2022

AhmedTElthakeb commented Apr 12, 2022

anhappdev commented May 31, 2022

freedomtan commented May 31, 2022

freedomtan commented Jun 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

freedomtan commented Jun 2, 2022

freedomtan commented Jun 2, 2022 • edited Loading

anhappdev commented Jun 4, 2022

github-actions bot commented Mar 15, 2022 •

edited

Loading

freedomtan commented Mar 29, 2022 •

edited

Loading

freedomtan commented Jun 2, 2022 •

edited

Loading