-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DynamicHMC and Turing support into extensions #114
Conversation
Codecov ReportBase: 92.64% // Head: 92.65% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 92.64% 92.65% +0.01%
==========================================
Files 13 13
Lines 571 572 +1
==========================================
+ Hits 529 530 +1
Misses 42 42
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The following cell in the docs build fails: Pathfinder.jl/docs/src/examples/turing.md Lines 105 to 107 in 7d2ce56
This happens because |
On Julia v1.9 and newer versions, this PR makes the DynamicHMC and Turing support into extensions. This will make it easier to keep compats up-to-date and allows for precompilation of the glue code.
On older Julia versions, Requires is used to conditionally load the extensions.
Until JuliaRegistries/Registrator.jl#397 is merged, this will need to be registered using LocalRegistry#master. Since this usage isn't documented, it's probably best to wait for the above PR to be merged so we can use JuliaRegistrator.