Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify input options. Only "p, w, c" matters. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify input options. Only "p, w, c" matters. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions horowitz_sahni.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
'''

''' Performs, iteratively, the Horowitz-Sahni algorithms for 0-1 KP problem.
INVARIANT: the elements to put in the knapsack must be ordered according
to the ratio value/cost (vector e), from the highest to the lowest.
Tries to add as much elements to the set as possible according to their
scaled value ("forward move") and then, when it funds a critical element
(i.e. one that cannot be added to the knapsack) estimates an upper bound
Expand All @@ -19,10 +17,6 @@

@param p: List of elements' values;
@param w: List of elements' weights;
@param e: List of elements' scaled values: e[i] = p[i]/w[i]
The elements available are sorted according to the 'e' vector.
The i-th element has value p[i], weight w[i].
@param N: The number of elements available;
@param c: Total capacity of the knapsack;
@return: A tuple with 3 elements:
1) The best value found for the knapsack (the solution
Expand All @@ -31,10 +25,26 @@
3) A bitmask identifying the elements belonging to the
solution.
'''
def horowitz_sahni(p, w, e, N, c):
def horowitz_sahni(p, w, c):

if len(p) != len(w):
print('knapsack error - not matched length')
return 0, 0, []

# The number of elements available;
N = len(p)

if N == 0:
return 0, 0, []

# List of elements' scaled values: e[i] = p[i]/w[i]
# The elements available are sorted according to the 'e' vector.
# The i-th element has value p[i], weight w[i].
e = [p[i] / w[i] for i, _ in enumerate(p)]

# the elements to put in the knapsack must be ordered according
# to the ratio value/cost (vector e), from the highest to the lowest.
e, p, w = zip(*sorted(zip(e, p, w), reverse=True))

mask = [0] * N
best_solution_mask = mask[:]
Expand Down