Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete YOLO class examples #1183

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bomanimc
Copy link
Member

Fixes #1145.

Since we no longer support YOLO as a singular modal and have hidden it from our documentation, I think we should also delete the examples.

This PR doesn't delete the ObjectDetector/YOLO implementation, as YOLO can still be used for the ObjectDetector class. That said, I don't have much context on the YOLO deprecation and I'm curious if this something we might want to delete too in a later PR (cc @joeyklee).

@bomanimc bomanimc requested a review from joeyklee April 16, 2021 03:34
@bomanimc bomanimc changed the title Bomani.delete yolo examples Delete YOLO class examples Apr 16, 2021
@joeyklee
Copy link
Contributor

(Ack! I recently turned off my github email notifications and realized I've missed SO much 🙈 . )

This PR doesn't delete the ObjectDetector/YOLO implementation, as YOLO can still be used for the ObjectDetector class. That said, I don't have much context on the YOLO deprecation and I'm curious if this something we might want to delete too in a later PR

  • Yes I think we can remove YOLO from the Object Detector entirely. The way I kind of see it right now, is that we are starting to land on these kind of "high level" model support -- e.g. object detector, face tracking, hand tracking, pose tracking -- and we have some pre-trained model that allows them to run. In ttrying to forefront maintainability, I think it doesn't hurt us to prune things out while we find our bearings amidst such quick growth and all the world happenings, and then work to add things back or build on top of as capacity permits. Does that resonate at all?

Copy link
Contributor

@joeyklee joeyklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM -- Before merging, I would just double check with @shiffman to sync up regarding potential coding train videos needing to update references.

@shiffman
Copy link
Member

I'm good with this change, I may have referenced YOLO in some tutorials but I can update video descriptions / code examples to use COCOSSD only.

@joeyklee joeyklee added the SEMVER/minor a version tag for a minor release change label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for release SEMVER/minor a version tag for a minor release change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove YOLO examples (and possibly delete source code)
3 participants