refact: Implement NetworkClient using async await #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbodsk
reviewed
Oct 25, 2022
Comment on lines
31
to
34
| return .init(pathUpdateStream: { | ||
| XCTFail("\(Self.self).pathUpdateStream method not implemented.") | ||
| fatalError("\(Self.self).pathUpdateStream method not implemented.") | ||
| }) |
There was a problem hiding this comment.
Suggested change
| return .init(pathUpdateStream: { | |
| XCTFail("\(Self.self).pathUpdateStream method not implemented.") | |
| fatalError("\(Self.self).pathUpdateStream method not implemented.") | |
| }) | |
| return .init(pathUpdateStream: { | |
| XCTUnimplemented("\(Self.self).pathUpdateStream method not implemented.") | |
| }) |
There was a problem hiding this comment.
I've just refactored our implementation to use async/await too and the above was suggested to me by Jakob so now I'm passing it on 😄
FabioMSousa
force-pushed
the
feature/networkClient-update
branch
from
bb84952 to
82bfc01
Compare
FabioMSousa
commented
Oct 25, 2022
Modules/Package.swift
Outdated
| @@ -29,7 +29,7 @@ let package = Package( | |||
| .package(url: "https://github.com/pointfreeco/swift-identified-collections", from: "0.3.2"), | |||
| .package(url: "https://github.com/pointfreeco/combine-schedulers", from: "0.5.3"), | |||
| .package(url: "https://github.com/pointfreeco/swiftui-navigation", from: "0.1.0"), | |||
| .package(url: "https://github.com/pointfreeco/xctest-dynamic-overlay", from: "0.2.1"), | |||
| .package(url: "https://github.com/pointfreeco/xctest-dynamic-overlay", from: "0.3.0"), | |||
There was a problem hiding this comment.
Changed the version so we could use XCTUnimplemented.
FabioMSousa
force-pushed
the
feature/networkClient-update
branch
from
82bfc01 to
fc6eeae
Compare
jakobmygind
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace combine implementation with async await.