Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose itemsize and nbytes as for numpy arrays #284

Merged
merged 1 commit into from
Dec 25, 2023
Merged

expose itemsize and nbytes as for numpy arrays #284

merged 1 commit into from
Dec 25, 2023

Conversation

dastrobu
Copy link
Contributor

see:

relates to ml-explore/mlx-examples#174

Proposed changes

Please include a description of the problem or feature this PR is addressing. If there is a corresponding issue, include the issue #.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@dastrobu
Copy link
Contributor Author

follow up of ml-explore/mlx-examples#174 (comment) (relates to ml-explore/mlx-examples#174)

awni
awni approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks!

@awni awni merged commit d58ac08 into ml-explore:main Dec 25, 2023
awni pushed a commit that referenced this pull request Dec 25, 2023
@dastrobu @awni
expose itemsize and nbytes as for numpy arrays (#284)
59608a7 
see:
  * https://numpy.org/doc/stable/reference/generated/numpy.ndarray.nbytes.html
  * https://numpy.org/doc/stable/reference/generated/numpy.ndarray.itemsize.html

relates to ml-explore/mlx-examples#174
@dastrobu dastrobu deleted the nbytes-and-itemsize branch December 26, 2023 12:58
Jyun1998 pushed a commit to Jyun1998/mlx that referenced this pull request Jan 7, 2024
@dastrobu @Jyun1998
expose itemsize and nbytes as for numpy arrays (ml-explore#284)
f0fe276 
see:
  * https://numpy.org/doc/stable/reference/generated/numpy.ndarray.nbytes.html
  * https://numpy.org/doc/stable/reference/generated/numpy.ndarray.itemsize.html

relates to ml-explore/mlx-examples#174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dastrobu @awni