Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upload to hub for HF LLMs conversion script. #221

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Fix upload to hub for HF LLMs conversion script. #221

merged 3 commits into from
Jan 4, 2024

Conversation

Vaibhavs10
Copy link
Contributor

No description provided.

@Vaibhavs10 Vaibhavs10 mentioned this pull request Jan 4, 2024
Merged
@Vaibhavs10 Vaibhavs10 mentioned this pull request Jan 4, 2024
Open
@Vaibhavs10
Copy link
Contributor Author

Vaibhavs10 commented Jan 4, 2024 •
edited
Loading

The last change is the name the safetensors w/ model. format. This allows our internal processes to parse the safetensors file and add a pretty visualisation like here: Mistral-7B-Instruct-v0.2.

Edit: Reverted this commit since this is would be a bit more involved discussion.

awni
awni approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@awni awni merged commit f95cf30 into ml-explore:main Jan 4, 2024
@Vaibhavs10 Vaibhavs10 deleted the fix_conversion_script branch January 4, 2024 14:13
Blaizzy pushed a commit to Blaizzy/mlx-examples that referenced this pull request Mar 13, 2024
@Vaibhavs10
Fix upload to hub for HF LLMs conversion script. (ml-explore#221)
a9ee883 
* Fix upload to hub snippet.

* Weights -> model.

* reverting last commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

@pcuenca pcuenca pcuenca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vaibhavs10 @pcuenca @awni