Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use string instead of enum type to avoid codegen fails #129

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

migueldaipre
Copy link
Contributor

@migueldaipre migueldaipre commented Aug 1, 2024

Description

Codegen does not support Union Types and Enums.

Closes #127 #128

Tests

You should be able to install the dependencies

@mkuczera mkuczera merged commit a658a60 into mkuczera:master Aug 2, 2024
@RahulSocialDev
Copy link

This is not refelected on npm, so while installing or upgrading to 2.3.0 is not solving this. Could we release another version 2.3.1 on npm

@migueldaipre migueldaipre deleted the fix/codegen-enum-support branch August 2, 2024 13:47
@mkuczera
Copy link
Owner

mkuczera commented Aug 2, 2024

@RahulSocialDev Sorry for the waiting. But since a few releases were buggy i´m currently in implementing proper checks to avoid this in the future. Should be latest tomorrow ready.

@mkuczera
Copy link
Owner

mkuczera commented Aug 3, 2024

Can be verified in "2.3.1-next.0".
https://www.npmjs.com/package/react-native-haptic-feedback/v/2.3.1-next.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Union types are unsupported in structs
3 participants