More BDouble operations #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twodayslate
force-pushed
the
bdouble
branch
2 times, most recently
from
c1a15c9 to
ec0196e
Compare
|
Very nice! We just need to implement more tests, I neglected that in the beginning, but it's necessary for high quality code |
|
Agreed. And more docstrings. Will work on this for my next PR. I don't know how to do pow or modulo for BDouble btw. |
|
Great, I will start doing that too. I have some scripts from university laying around, I'll look up how to do exponentiation and modulus with fractions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #19
Let me know if there is a better way to do this.