feat: Migrate shell scripts for cookiecutter e2e tests to Nox. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkranna
changed the title
mkranna
force-pushed
the
noxfile_for_cookiecutter
branch
from
102da3e to
2da3353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes meltano#1423: Migrate shell scripts for cookiecutter e2e tests to Nox.
First, I added a new parametrised session
test_cookiecutterto the main projectnoxfile.py, which replaces thetest_cookiercutter.sh(parametrised by the json-files in e2e-tests/cookiecutter folder). To run all cookiecutter replay files, use the following terminal command:nox --session=test_cookiecutter.Second, I updated the
cookiecutter-e2e.ymlto simply call the nox session as above. It is no longer required to maintain a list of the replay files in that YML.Comment: the advantage of the current
cookiecutter-e2e.ymlis that is it no longer lists replay files, but on the other hand the tests takes longer since they are not run in parallel. Alternatively, I can call tests in parallel as it was done before.📚 Documentation preview 📚: https://meltano-sdk--3.org.readthedocs.build/en/3/