userspace: Correctly set ip offload flag in native tunneling.

Coverity identified the following issue CID 425094: (openvswitch#1 of 1): Unchecked return value (CHECKED_RETURN) 4. check_return: Calling dp_packet_hwol_tx_ip_csum without checking return value (as is done elsewhere 9 out of 11 times). This appears to be a true positive, the fields getter was called instead of its setter. Fixes: 084c808 ("userspace: Support VXLAN and GENEVE TSO.") Reported-by: Eelco Chaudron <[email protected]> Signed-off-by: Mike Pattrick <[email protected]>
mkp-rh · Aug 27, 2024 · 6f2359f · 6f2359f
1 parent dbeabcc
commit 6f2359f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
@@ -254,7 +254,7 @@ dp_packet_tnl_ol_process(struct dp_packet *packet,
 
             if (IP_VER(ip->ip_ihl_ver) == 4) {
                 dp_packet_hwol_set_tx_ipv4(packet);
-                dp_packet_hwol_tx_ip_csum(packet);
+                dp_packet_hwol_set_tx_ip_csum(packet);
             } else if (IP_VER(ip->ip_ihl_ver) == 6) {
                 dp_packet_hwol_set_tx_ipv6(packet);
             }