-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thead is deleted from resulting table after calling destroy when Absolute Positioning is off and the table was initialized while hidden #127
Comments
any chance for a jsfiddle? |
I figured it out better while making that jsfiddle. and will update the issue after posting this comment. steps to reproduce: hide table, float thead abs=off, show table (optional, can be done at the end), unfloat thead. Tested in firefox 32.0.3 Basically destroying a fixed pos table that was initialized while the table was not visible deletes the thead. Initializing a table while it is not visible has its own set of issues, but none that can't be solved by reflowing or refloating the table. The only reason i still consider this a bug worthy of reporting is because it deletes the thead node. |
Thanks, Ive needed to address the weirdness that happens when the table is hidden for a while now. This jsfiddle gives me a good starting point. |
made hidden table handling better - if the table is hidden when floatThead is called, its not so bad now.
I have a fix on my doc site - havent pushed it up to master yet. You can check it out: http://mkoryak.github.io/floatThead/tests/issue-127/ Thanks for finding this, I couldn't have stumbled on it unless I was stoned. |
Hey, this is now fixed on master. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What it says on the tin. When you call destroy on a table that has absolute positioning turned off and table was initialized while hidden, it will lose it thead. As in, the actual thead object/node no longer exists in the dom.
Version v1.2.9-0-g997917e
Note: im using bootstrap 3 and some of my tables are in collapsing panels, so i have a bit of code to make thead play nice with that.
Almost all pages have mutiple tables, so that may play a part.
This worked fine until i tried turning off absolute positioning to make it play nice with chrome.
here is all code for initializing and destroying floatthead (this is in the sites global js file)
Note:This code, with the
useAbsolutePositioning : false
part removed, works fine.The text was updated successfully, but these errors were encountered: