.github/workflows/dist.yml: Upload PyPI sdists also as GH Release Assets

mkoeppe · Aug 16, 2024 · 226a916 · 226a916
1 parent e042294
commit 226a916
Showing 1 changed file with 21 additions and 18 deletions.
diff --git a/.github/workflows/dist.yml b/.github/workflows/dist.yml
@@ -76,24 +76,6 @@ jobs:
             upstream
           name: release_dist
 
-  release:
-
-    needs: release_dist
-    runs-on: ubuntu-latest
-    if: (success() || failure()) && github.repository == 'sagemath/sage' && startsWith(github.ref, 'refs/tags/') && !contains(github.ref, 'beta') && !contains(github.ref, 'rc')
-    steps:
-      - uses: actions/download-artifact@v4
-        with:
-          name: release_dist
-      - uses: softprops/action-gh-release@v2
-        with:
-          generate_release_notes: true
-          files: |
-            dist/*
-            upstream/*
-    permissions:
-      contents: write
-
   sdists_for_pypi:
 
     runs-on: ubuntu-latest
@@ -124,6 +106,27 @@ jobs:
           verbose: true
         if: env.CAN_DEPLOY == 'true'
 
+  release:
+
+    needs: [release_dist, sdists_for_pypi]
+    runs-on: ubuntu-latest
+    if: (success() || failure()) && github.repository == 'sagemath/sage' && startsWith(github.ref, 'refs/tags/') && !contains(github.ref, 'beta') && !contains(github.ref, 'rc')
+    steps:
+      - uses: actions/download-artifact@v4
+        with:
+          name: release_dist
+      - uses: actions/download-artifact@v4
+        with:
+          name: dist
+      - uses: softprops/action-gh-release@v2
+        with:
+          generate_release_notes: true
+          files: |
+            dist/*
+            upstream/*
+    permissions:
+      contents: write
+
   noarch_wheels_for_pypi:
 
     runs-on: ubuntu-latest