Use M1 runner for macOS arm64 wheels #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new macos-14 (M1) runner for creating ARM64 wheels. In the Github Action artifacts script, separate out the various platforms for clarity. Update actions/setup-python to v5 to suppress node deprecation warning. Update, and pin, other actions accordingly.
Appveyor builds are slow and sequential, so do the most important one first, i.e. Python 3.12.
Version 2 of github/codeql-action is now deprecated.
|
You can see examples of the wheels that are generated here: https://github.com/keitherskine/pyodbc/actions/runs/7775109101 This should hopefully fix #1124 . |
|
I have tested the arm64 wheel on an M1 Macbook Pro. If anybody can test it on an M3 that would be appreciated. |
|
This is amazing @keitherskine . I was looking into this as soon as I got the email from Github about the new runners, but you are way ahead of me, as usual. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that GitHub has made an ARM64 runner available - hurrah! - let's use it to create the problematic macOS ARM64 wheels.
In the GitHub Action artifacts script, I have separated out the builds for each platform into discrete jobs. They are all slightly different and it seems sensible to have a specific job for each platform.
We were getting a bunch of deprecation warnings about old versions of node, so I have updated the versions of actions/setup-python from v4 to v5, actions/upload-artifact from v3 to v4, and github/codeql-action from v2 to v3. I have also taken the opportunity to pin various actions to specific minor versions so we know exactly what is being run.
Lastly, I have swapped around the Appveyor builds so that Python 3.12 is done first and Python 3.8 is done last. On the free plan, Appveyor jobs are sequential (and slow), and typically it's the Python 3.12 build we are most interested in, so do it first.