Handle bytes in the attrs_before parameter for pyodbc.connect() #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the code to handle byte values in the attrs_before parameter was lost in the v5 upgrade. Adding it back in.
|
@keitherskine Thanks for this. I believe when I was porting I was thinking everything should be text and I should take out bytes. BTW, after this is merged, I should probably add an error to say "type XXX is not supported". If that existed before, people would have seen "type bytes is not supported" and would have sped up the process of troubleshooting. |
|
Ha. The new error message I added would not have helped in this case. One of the checks below is for a sequence, which bytes are. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix the segfault issue #1289 .
It looks like the code to handle byte values in the attrs_before parameter was lost in the v5 upgrade. I've copied the original code back in. The only difference is I've replaced the call to PyBytes_AS_STRING with the stable ABI compliant call to PyBytes_AsString.
@mkleehammer / @v-chojas / @gordthompson , I haven't been able to properly test this though, so do please check what I've done.