Skip to content

Commit

Permalink
chore: Update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
pawamoy committed Dec 26, 2024
1 parent 0279998 commit eea0af1
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions src/_griffe/loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,18 +189,7 @@ def _post_load(self, module: Module, obj_path: str) -> Object | Alias:
# Pre-emptively expand exports (`__all__` values),
# as well as wildcard imports (without ever loading additional packages).
# This is a best-effort to return the most correct API data
# before firing the `on_package_loaded` event,
# because extensions registering hooks for this event
# might trigger computation of inherited members,
# which are cached, and could be cached too early
# (aliases to base class still being unresolvable,
# preventing to fetch some inherited members).
#
# Another solution to this "too-early-computation-of-inherited-members"
# issue would be to stop caching resolved bases and inherited members,
# but we would have to measure the performance impact of this change,
# as each use of `obj["name"]` would compute resolved bases, MRO
# and inherited members again.
# before firing the `on_package_loaded` event.
#
# Packages that wildcard imports from external, non-loaded packages
# will still have incomplete data, requiring subsequent calls to
Expand Down

0 comments on commit eea0af1

Please sign in to comment.