Skip to content

Commit

Permalink
fix: Fix check command's Markdown output format not displaying parame…
Browse files Browse the repository at this point in the history
…ter names
  • Loading branch information
pawamoy committed Jan 9, 2025
1 parent 6842372 commit 5e7af22
Showing 1 changed file with 33 additions and 9 deletions.
42 changes: 33 additions & 9 deletions src/_griffe/diff.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,12 +195,12 @@ def _explain_verbose(self) -> str:
return "\n".join(lines)

def _explain_markdown(self) -> str:
explanation = f"- `{self._canonical_path}`: *{self.kind.value}*"
explanation = f"- `{self._relative_path}`: *{self.kind.value}*"
old = self._format_old_value()
if old != "unset":
if old and old != "unset":
old = f"`{old}`"
new = self._format_new_value()
if new != "unset":
if new and new != "unset":
new = f"`{new}`"
if old and new:
change = f"{old} -> {new}"
Expand Down Expand Up @@ -242,8 +242,12 @@ class ParameterMovedBreakage(Breakage):

kind: BreakageKind = BreakageKind.PARAMETER_MOVED

@property
def _relative_path(self) -> str:
return f"{super()._relative_path}({self.old_value.name})"

def _format_title(self) -> str:
return f"{self._relative_path}({Fore.BLUE}{self.old_value.name}{Fore.RESET})"
return f"{super()._relative_path}({Fore.BLUE}{self.old_value.name}{Fore.RESET})"

def _format_old_value(self) -> str:
return ""
Expand All @@ -257,8 +261,12 @@ class ParameterRemovedBreakage(Breakage):

kind: BreakageKind = BreakageKind.PARAMETER_REMOVED

@property
def _relative_path(self) -> str:
return f"{super()._relative_path}({self.old_value.name})"

def _format_title(self) -> str:
return f"{self._relative_path}({Fore.BLUE}{self.old_value.name}{Fore.RESET})"
return f"{super()._relative_path}({Fore.BLUE}{self.old_value.name}{Fore.RESET})"

def _format_old_value(self) -> str:
return ""
Expand All @@ -272,8 +280,12 @@ class ParameterChangedKindBreakage(Breakage):

kind: BreakageKind = BreakageKind.PARAMETER_CHANGED_KIND

@property
def _relative_path(self) -> str:
return f"{super()._relative_path}({self.old_value.name})"

def _format_title(self) -> str:
return f"{self._relative_path}({Fore.BLUE}{self.old_value.name}{Fore.RESET})"
return f"{super()._relative_path}({Fore.BLUE}{self.old_value.name}{Fore.RESET})"

def _format_old_value(self) -> str:
return str(self.old_value.kind.value)
Expand All @@ -287,8 +299,12 @@ class ParameterChangedDefaultBreakage(Breakage):

kind: BreakageKind = BreakageKind.PARAMETER_CHANGED_DEFAULT

@property
def _relative_path(self) -> str:
return f"{super()._relative_path}({self.old_value.name})"

def _format_title(self) -> str:
return f"{self._relative_path}({Fore.BLUE}{self.old_value.name}{Fore.RESET})"
return f"{super()._relative_path}({Fore.BLUE}{self.old_value.name}{Fore.RESET})"

def _format_old_value(self) -> str:
return str(self.old_value.default)
Expand All @@ -302,8 +318,12 @@ class ParameterChangedRequiredBreakage(Breakage):

kind: BreakageKind = BreakageKind.PARAMETER_CHANGED_REQUIRED

@property
def _relative_path(self) -> str:
return f"{super()._relative_path}({self.old_value.name})"

def _format_title(self) -> str:
return f"{self._relative_path}({Fore.BLUE}{self.old_value.name}{Fore.RESET})"
return f"{super()._relative_path}({Fore.BLUE}{self.old_value.name}{Fore.RESET})"

def _format_old_value(self) -> str:
return ""
Expand All @@ -317,8 +337,12 @@ class ParameterAddedRequiredBreakage(Breakage):

kind: BreakageKind = BreakageKind.PARAMETER_ADDED_REQUIRED

@property
def _relative_path(self) -> str:
return f"{super()._relative_path}({self.new_value.name})"

def _format_title(self) -> str:
return f"{self._relative_path}({Fore.BLUE}{self.new_value.name}{Fore.RESET})"
return f"{super()._relative_path}({Fore.BLUE}{self.new_value.name}{Fore.RESET})"

def _format_old_value(self) -> str:
return ""
Expand Down

0 comments on commit 5e7af22

Please sign in to comment.