Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build.yml to build for amd64 and arm64 #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ckuhtz
Copy link

@ckuhtz ckuhtz commented Jan 8, 2025

I have not tested this, but this should be accurate or mostly accurate as an example for what the github issue is requesting.

@ckuhtz ckuhtz mentioned this pull request Jan 8, 2025
@mkasberg
Copy link
Owner

mkasberg commented Jan 8, 2025

I think the concept here will work.

I have a hunch that the docker/setup-qemu-action will require our build to be in Docker. I haven't confirmed this, I need to read more docs. If the build does need to be in Docker, that's possible, I prototyped it in #2 but was on the fence about if that was the right approach. Seems like it is a better approach if it unlocks builds on more architectures for us. (I might need to update/rebase that old PR for recent changes in main.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants