[Report Scheduler] Empty node pool handling (project-chip#31136)

* Changed check for no nodes in pool * Update src/app/reporting/SynchronizedReportSchedulerImpl.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
mkardous-silabs · Dec 21, 2023 · bd24a65 · bd24a65
1 parent 2544b6e
commit bd24a65
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/app/reporting/SynchronizedReportSchedulerImpl.cpp b/src/app/reporting/SynchronizedReportSchedulerImpl.cpp
@@ -182,6 +182,9 @@ void SynchronizedReportSchedulerImpl::TimerFired()
     Timestamp now   = mTimerDelegate->GetCurrentMonotonicTimestamp();
     bool firedEarly = true;
 
+    // If there are no handlers registered, no need to do anything.
+    VerifyOrReturn(mNodesPool.Allocated());
+
     mNodesPool.ForEachActiveObject([now, &firedEarly](ReadHandlerNode * node) {
         if (node->GetMinTimestamp() <= now)
         {
@@ -201,8 +204,7 @@ void SynchronizedReportSchedulerImpl::TimerFired()
         return Loop::Continue;
     });
 
-    // If there are no handlers registers, no need to schedule the next report
-    if (mNodesPool.Allocated() && firedEarly)
+    if (firedEarly)
     {
         Timeout timeout = Milliseconds32(0);
         ReturnOnFailure(CalculateNextReportTimeout(timeout, nullptr, now));