Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Andrei Litvin <[email protected]>
  • Loading branch information
mkardous-silabs and andy31415 authored Jul 26, 2024
1 parent ebca97f commit acb71f9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/app/icd/server/DefaultICDCheckInBackOffStrategy.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class DefaultICDCheckInBackOffStrategy : public ICDCheckInBackOffStrategy
/**
* @brief Function checks if the entry is a permanent or ephemeral client.
* If the client is permanent, we should send a Check-In message.
* If the cliet is ephemerakl, we should not send a Check-In message.
* If the cliet is ephemeral, we should not send a Check-In message.
*
* @param entry Entry for which we are deciding if we need to send a Check-In message or not.
* @return true If the client is permanent, return true.
Expand Down
2 changes: 1 addition & 1 deletion src/app/icd/server/ICDCheckInBackOffStrategy.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class ICDCheckInBackOffStrategy
* @param entry ICDMonitoringEntry for which we are about to send a Check-In message to.
*
* @return true ICDCheckInBackOffStrategy determines that we SHOULD send a Check-In message to the given entry
* @return falseI CDCheckInBackOffStrategy determines that we SHOULD NOT send a Check-In message to the given entry
* @return false ICDCheckInBackOffStrategy determines that we SHOULD NOT send a Check-In message to the given entry
*/
virtual bool ShouldSendCheckInMessage(const ICDMonitoringEntry & entry) = 0;

Expand Down
4 changes: 2 additions & 2 deletions src/app/server/Server.h
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ struct ServerInitParams
Credentials::OperationalCertificateStore * opCertStore = nullptr;
// Required, if not provided, the Server::Init() WILL fail.
app::reporting::ReportScheduler * reportScheduler = nullptr;
// Optionnal. Support for the ICD Check-In BackOff strategy. Must be initialized before being provided.
// If the ICD Check-In protocol use-case is supported and no strategy is prprovided, server will use the default strategy.
// Optional. Support for the ICD Check-In BackOff strategy. Must be initialized before being provided.
// If the ICD Check-In protocol use-case is supported and no strategy is provided, server will use the default strategy.
app::ICDCheckInBackOffStrategy * icdCheckInBackOffStrategy = nullptr;
};

Expand Down

0 comments on commit acb71f9

Please sign in to comment.