Enhance get helper to support hash parameters.
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't used yet, but will allow the helper to modify the context (useful for #10).
Hash parameters for the `get` helper work the same way as with partial include syntax. They may override Operator-set render data.
|
Whoops, I need to support hash params for executables too! |
This doesn't always guarantee a deterministic order when dealing with the new hash params, which can cause some snapshot tests of content passing multiple hash params to sporadically fail (because of differing order of serialized JSON object properties, since the tests just use dumb string equality checks). `preserve_order` is also not necessary to get a stable ordering (since serde_json uses a `BTreeMap` by default), and there's probably a small performance benefit to turning off the feature (though I haven't measured).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash parameters for the
gethelper work the same way as with partial include syntax. They may override Operator-set render data.Contributes to #10.