Factory-ize wrapper creation to allow React Native support #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DveMac thanks this is great! Are you using this with your react native app? Im curious how well it plays with https://github.com/aksonov/react-native-router-flux and if I should make an example since react-router doesn't support native |
|
Im currently using react-router-redux and react-router (not a react native specific apdater). React router I can pass my own history object and therefore use almost the entirely same routing setup across react and react native versions of the app. Im not totally convinced its the way to go, but its where Im at right now! |
|
Thanks for the info, I was planning on playing with my first React Native app so helpful to hear that the custom history works well in native. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Missing react native specific unit tests)