Replace openItem by openExternal to try to make it work on osx

related to #146
mjmlio · Jun 10, 2017 · 816e38f · 816e38f
1 parent 3201c15
commit 816e38f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/app/actions/queryLastVersion.js b/app/actions/queryLastVersion.js
@@ -41,7 +41,7 @@ export default function queryLastVersion () {
             primary
             className='mt-20'
             onClick={() => {
-              shell.openItem(getDownloadURL())
+              shell.openExternal(getDownloadURL())
             }}
           >
             <IconDownload className='mr-5' />

diff --git a/app/components/ErrorModal/index.js b/app/components/ErrorModal/index.js
@@ -78,7 +78,7 @@ class ErrorModal extends Component {
           <pre>{stack}</pre>
         </div>
         <div className='d-f ai-c jc-c'>
-          <Button primary onClick={() => shell.openItem('https://github.com/mjmlio/mjml-app/issues')}>
+          <Button primary onClick={() => shell.openExternal('https://github.com/mjmlio/mjml-app/issues')}>
             <IconOpen className='mr-5' />
             {'Open the issues page'}
           </Button>

diff --git a/app/components/Iframe/index.js b/app/components/Iframe/index.js
@@ -48,7 +48,7 @@ class Iframe extends Component {
             e.preventDefault()
             const href = link.getAttribute('href')
             if (href) {
-              shell.openItem(href)
+              shell.openExternal(href)
             }
           })
         })

diff --git a/app/menu.js b/app/menu.js
@@ -24,12 +24,12 @@ export default function buildMenu (mainWindow) {
       }, {
         label: 'Documentation',
         click () {
-          shell.openItem('https://mjml.io/documentation/')
+          shell.openExternal('https://mjml.io/documentation/')
         },
       }, {
         label: 'Browser Editor',
         click () {
-          shell.openItem('https://mjml.io/try-it-live')
+          shell.openExternal('https://mjml.io/try-it-live')
         },
       }, {
         type: 'separator',